Revert testNow behavior in createFromFormat for BC#503
Merged
dereuromark merged 1 commit into3.xfrom Mar 14, 2026
Merged
Conversation
dereuromark
force-pushed
the
revert-testnow-createfromformat
branch
from
094a06d to
b8cdd8c
Compare
dereuromark
changed the title
The change in 3.3.2 that made createFromFormat respect testNow for missing components was a BC break. This reverts that behavior. createFromFormat now behaves exactly like PHP's native DateTimeImmutable::createFromFormat - testNow has no effect. The testNow feature for createFromFormat may be re-added as opt-in in a future major version.
dereuromark
force-pushed
the
revert-testnow-createfromformat
branch
from
b8cdd8c to
41a94b8
Compare
dereuromark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the testNow behavior change in
createFromFormat()introduced in 3.3.2 for BC compatibility.The Problem
The change in 3.3.2 that made
createFromFormat()respecttestNowfor missing components was a BC break. Users expectcreateFromFormat()to behave exactly like PHP's nativeDateTimeImmutable::createFromFormat().The Fix
createFromFormat()now behaves exactly like PHP's native method -testNowhas no effect on it.The testNow feature for
createFromFormat()may be re-added as opt-in in a future major version.