Skip to content

Cake2.x#35

Closed
dereuromark wants to merge 4 commits intocakephp:masterfrom
dereuromark:cake2.x
Closed

Cake2.x#35
dereuromark wants to merge 4 commits intocakephp:masterfrom
dereuromark:cake2.x

Conversation

@dereuromark
Copy link
Copy Markdown
Member

  • libs to panel package
  • coding standards correction and strict fixes
  • settings via configure
  • tidy panel

see http://cakephp.lighthouseapp.com/projects/42880/tickets/51-20using-lib-directory

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when $errors or $path contain spaces? I'm pretty sure *nix systems will have errors.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently works on windows and linux for me. but we might need some additional testing then.

@markstory
Copy link
Copy Markdown
Member

The changes here cause 2 failures and 8 errors in the test cases. Also I'm not entirely sold on the Tidy panel, when its off by default. I might just end up removing it. It depends on additional C extensions / External programs to be installed.

@markstory
Copy link
Copy Markdown
Member

I'm going to fix the tests as I've never been overly happy with the debug kit test suite anyways.

@markstory
Copy link
Copy Markdown
Member

I've merged the changes so far into the lib-cleanup branch. I'm still on the fence about the Tidy panel though.

@markstory markstory closed this May 6, 2012
@dereuromark
Copy link
Copy Markdown
Member Author

well, then go ahead and remove that :) it can easily be "installed" manually if needed from the user land site. I just dropped it in the same plugin to keep it all in the same location at my own convenience.

@markstory
Copy link
Copy Markdown
Member

Merged into master now. Which also has been updated to use PHP5.3 and CakePHP 2.1+

dogmatic69 pushed a commit to dogmatic69/debug_kit that referenced this pull request Nov 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants