Don't double load jQuery

[markstory]

If jQuery is on the page and has the features DebugKit needs, don't download another copy. If jQuery is absent make a blocking XHR request to fetch it and use eval LIKE A BOSS.

[ADmad]

👍

[AD7six]

Think we'll need a better test than my original suggestion

"1.8.0" >= "1.8.1"
false
"1.8.1" >= "1.8.1"
true
"1.9.1" >= "1.8.1"
true
"1.10.0" >= "1.8.1"
false <---
"2.0.0" >= "1.8.1"
true

[AD7six]

👍

Though as commented the version compare function needs some adjusting. Do we need min and max? Seems a bit risky to only provide a minimum and therefore leave the door open to using an incompatible major version i the future.

I'm not sure of the right logic to suggest but e.g. a simple implementation could be like:

function jqueryVersionOk(version, min, max) {

    // return true if first is >= second
    function compare(first, second) {
        var i,
            firstVersion = first.split('.'),
            secondVersion = second.split('.');

        for(i = 0; i < secondVersion.length; i++) {
            if (isNaN(firstVersion[i])) {
                return false;
            }
            if (firstVersion[i] > secondVersion[i]) {
                return true;
            }
            if (firstVersion[i] < secondVersion[i]) {
                return false;
            }
        }

        return true; // exact version match to the precision of the second version
    }

    return compare(version, min) && !compare(version, max);
}

if (window.jQuery && jqueryVersionOk(jQuery.fn.jquery, '1.8', '2') {

[markstory]

Good point about limiting the upper boundary. I'll get that fixed.

[markstory]

I think I have the boundary conditions fixed.

[markstory]

I think I got it this time. I apologize about all the mistakes, my brain has been a bit mushy today.

versionWithin('1.10.1', '1.8', '2.0');
true
versionWithin('2.1.0', '1.8', '2.0');
false
versionWithin('1.8.1', '1.8', '2.0');
true
versionWithin('1.7.1', '1.8', '2.0');
false

[AD7six]

since the minimum length of the two variables are used - this looks like it's unreachable

[AD7six]

LGTM 👍

[bar]

I understand DebugKit needs 1.8.1 to work. But this particular merge began to cause trouble when the actual JQuery version, loaded before DebugKit, is lower than 1.8.

From master:
XMLHttpRequest.responseText ends up with JQuery version 1.8.1.,

And later jQuery.noConflict() sets JQuery global variable to 1.8.1. which makes some of the plugins previously loaded to fail.

From that line comment, it seem to be the desired intention, but I suggest using $ in DebugKit, and making that line $.noConflict(true) so that the JQuery global variable sticks with the previous version, which may be used by other code.

You can test it here:
http://jsbin.com/EVoZoroP/1/edit?html,js,output

[markstory]

@bar Thanks for the bin, I added noConflict(true).

[bar]

You are fast 👍 I was just about to issue the PR :p