Closed
Conversation
Dropped short tag echo notation. 1. It's used inconsistently 2. It adds a dependency on the server's php.ini to have `short_tags` set to on. Just echo'ing everything makes sure it works on every server, regardsless of it's configuration.
Member
Not for PHP5.4+ see http://php.net/manual/en/ini.core.php#ini.short-open-tag - and therefore in Cake3.0+ We cannot apply this patch without changing the official coding standards on this one, though. And they state that short tags are used for HTML inline PHP output in the view layer. |
Member
If you find an inconsistency please send a PR to update to short echo tag. |
Contributor
Author
|
@dereuromark Ah, didn't know they changed that. Interesting, thanks for sharing the info and link :-) |
Member
|
Refs cakephp/cakephp#2596 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped short tag echo notation.
short_tagsset to on. Just echoing everything makes sure it works on every server, regardless of it's configuration.