Add note about losing original values on save #4295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| components, as it does not extend ``AppController``. If you are enabling these | ||
| components through events, you will need to update your code. | ||
| * ``Entity::clean`` now cleans original values, clearing them on save. This | ||
| behavior was a bug, as the entity's original state should not persist a |
Member
There was a problem hiding this comment.
'original state should not be retained after a save'
Member
Author
There was a problem hiding this comment.
👍 Still include the bit below about the save reflecting the new state of the entity?
Member
Author
|
@markstory updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure about the wording on this, let me know if you want me to change it.
Refs cakephp/cakephp#9411