Update response chapter. #4537
Merged
Update response chapter. #4537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document new interfaces. * Include section on common mistakes with immutable objects. Refs cakephp/cakephp#9636
ravage84
reviewed
Dec 20, 2016
|
|
||
| Sending the Response | ||
| -------------------- | ||
| Common Mistakes with Immutable Responses |
Member
There was a problem hiding this comment.
I feel this note is way too far down the page.
Member
Author
There was a problem hiding this comment.
I thought it was kind of awkward at other positions in the page.
ravage84
reviewed
Dec 20, 2016
| .. meta:: | ||
| :title lang=en: Request and Response objects | ||
| :keywords lang=en: request controller,request parameters,array indexes,purpose index,response objects,domain information,request object,request data,interrogating,params,previous versions,introspection,dispatcher,rout,data structures,arrays,ip address,migration,indexes,cakephp | ||
| :keywords lang=en: request controller,request parameters,array indexes,purpose index,response objects,domain information,request object,request data,interrogating,params,previous versions,introspection,dispatcher,rout,data structures,arrays,ip address,migration,indexes,cakephp,PSR-7,immutable |
ravage84
approved these changes
Dec 20, 2016
| Query string parameters can be read using the ``getQuery()`` method:: | ||
|
|
||
| // URL is /posts/index?page=1&sort=title | ||
| $this->request->getQuery('page'); |
Member
There was a problem hiding this comment.
I would write $page = $this->request->getQuery('page');, this way it becomes even more clear. I think this is nov more important than before, as we now prefix all setter methods with a $response = .
Shall I open a separate PR after this gets merged?
HavokInspiration
added a commit
that referenced
this pull request
Jan 8, 2017
antograssiot
added a commit
that referenced
this pull request
Jan 10, 2017
[fr] 3.4 response docs update (follow #4537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs cakephp/cakephp#9636