[fr] 3.4 response docs update (follow #4537) #4584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cake17
reviewed
Jan 8, 2017
fr/controllers/request-response.rst
Outdated
| .. php:method:: withHeader($header, $value) | ||
| Les définitions de headers se font avec la méthode :php:meth:`Cake\\Http\\Response::withHeader()`. | ||
| Comme tous les méthodes de l'interface PSR-7, cette méthode retourne une |
cake17
reviewed
Jan 8, 2017
fr/controllers/request-response.rst
Outdated
| $this->response->withHeader('X-CakePHP', 'yes!'); | ||
|
|
||
| Dans le code ci-dessus, la réponse ne contiendra pas le header ``X-CakePHP`` | ||
| car la valeur retournée par ``withHeader()`` n'a pas été persisté. Pour avoir |
cake17
reviewed
Jan 8, 2017
|
|
||
| Définir les En-têtes de Requête d'Origine Croisée (Cross Origin Request Headers = CORS) | ||
| Définir les En-têtes de Requête d'Origine Croisée (Cross Origin ServerRequest Headers = CORS) | ||
| ======================================================================================= |
Member
Author
There was a problem hiding this comment.
Indeed and the "ServerRequest" should be "Request". The Search and Replace was a bit destructive.
Member
Author
|
Thanks for the review @cake17. I'll probably make the necessary changes tomorrow. |
Member
Author
|
@cake17 I took care of it. |
Contributor
|
Nice work @HavokInspiration |
Member
|
top @HavokInspiration ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4537 for the French docs.
I modified some things I think were missed in the original version, be sure to check it out before merging.