Add docs for saveOrFail and deleteOrFail #4722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dereuromark
reviewed
Feb 16, 2017
| Using this method will throw an :php:exc:`Cake\\ORM\\Exception\\PersistenceFailedException` | ||
| if the application rules checks failed, the entity contains errors or the save was aborted by a callback. | ||
| Using this can be helpful when you performing complex database operations without human monitoring, | ||
| for example, inside a Shell task. |
Member
There was a problem hiding this comment.
Should we add:
Do not use this for validation inside controller actions and where feedback to the user has to be given in forms.
etc?
Member
There was a problem hiding this comment.
One could use it there if they catch the exception.
Member
There was a problem hiding this comment.
Yeah but not without catching it then :)
Member
There was a problem hiding this comment.
'Do not use' is pretty strongly worded when it can be used if you catch the resulting exceptions.
Contributor
|
Edit: NVM thought it was a cakephp/app docker ;) |
Contributor
|
@inoas you should have a look to the readme. |
bcrowe
reviewed
Feb 17, 2017
| echo $e->getEntity(); | ||
| } | ||
|
|
||
| As this internally perfoms a :php:meth:`Cake\\ORM\\Table::delete()` call, all corresponding delete events will be triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in cakephp/cakephp#10164, here are the docs for
Cake\ORM\Table::saveOrFail()andCake\ORM\Table::deleteOrFail().I hope I covered everything necessary.
On a site note, using the provided Dockerfile worked like a charme 👍