Fix findTagged "no tags" query in bookmarks tutorial. #4920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is a bug in the exising findTagged function. When calling the function without any tags specified all bookmarks are returned, rather than the bookmarks that have no associated tags. - The alternative query (tags specified) was also adjusted to use a similar approach - specifying the conditional after the join, rather than in it, IMHO making the logic a little clearer.
Contributor
Author
|
For a short discussion of why the conditional in the left join does not work the same as a where clause please see: http://stackoverflow.com/questions/354070/sql-join-where-clause-vs-on-clause |
Contributor
Author
|
On a related note the paragraph that follows the findTagged code sample discusses the much older version of that function (changed in PR #4609). That paragraph should be updated to match the new code example. But I guess we should wait until everyone is happy with the function before making that change. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function without any tags specified all bookmarks are returned, rather
than the bookmarks that have no associated tags.
similar approach - specifying the conditional after the join, rather
than in it, IMHO making the logic a little clearer.