Add docs for testing flash messages. #4971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ack! Thank you! I always forget the docs, feel free to ping me in the future about adding them 😄 |
ravage84
approved these changes
May 16, 2017
Member
ravage84
left a comment
ravage84
left a comment
There was a problem hiding this comment.
Looks good, except that CakePHP 3.4.7 is not released yet, but due to 2017-05-21:
https://github.com/cakephp/cakephp/milestone/132
| $expected = [ | ||
| ['id' => 1, 'lng' => 66, 'lat' => 45], | ||
| ]; | ||
| $expected = json_encode($expected, JSON_PRETTY_PRINT); |
Member
There was a problem hiding this comment.
Isn't there an assertion taht does JSON encoding already?
| public function testGet() | ||
| { | ||
| $this->configRequest([ | ||
| 'headers' => ['Accept' => 'application/json'] |
Member
There was a problem hiding this comment.
Since this could be quite common, I presume, couldn't we have a setAcceptsJson() or something like that?
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
May 23, 2017
HavokInspiration
added a commit
that referenced
this pull request
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs cakephp/cakephp#10626