Skip to content

Conversation

@markstory
Copy link
Member

@markstory markstory added this to the 3.x milestone May 18, 2017
Copy link
Member

@ravage84 ravage84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

endpoints.

.. versionadded:: 3.5.0
The ``CsrfProtectionMiddleware`` was added in 3.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this note be under "Cross Site Request Forgery (CSRF) Middleware"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should.

@markstory markstory merged commit 5931ee4 into 3.next May 19, 2017
@markstory markstory deleted the more-middleware branch May 19, 2017 01:54
----------------------------------

In addition to request data parameters, CSRF tokens can be submitted through
a special ``X-CSRF-Token`` header. Using a header often makes it easier to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point to docs how to do it?
Is it enabled by default?
Should it?

Copy link
Member Author

@markstory markstory May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting headers is part of whatever client library you happen to be using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants