-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Added note about generating coverage with phpdbg #4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
en/development/testing.rst
Outdated
| should be able to view the results by going to | ||
| ``http://localhost/your_app/coverage``. | ||
|
|
||
| If you are using PHP 5.6.0 or greater, you can use `phpdbg <http://phpunit.de/manual/current/en/installation.html#installation.phar.windows>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you link to #installation.phar.windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy paste fail :(
| ``http://localhost/your_app/coverage``. | ||
|
|
||
| If you are using PHP 5.6.0 or greater, you can use `phpdbg <http://phpunit.de/manual/current/en/installation.html#installation.phar.windows>`__ | ||
| to generate coverage instead of xdebug. ``phpdbg`` is generally faster at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That it is "generally faster" is probably true. Simply because it has less functionality. Some of Xdebugs functionality makes it way slower. Some of it could be disabled, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question is: Is that really relevant (as part of the CookBook)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether it's relevant or not is totally up for debate. I hesitate to put it here as it's an additional tool and isn't cakephp related. However, there is other non-cakephp information (like this section in the first place) so I thought it might be helpful.
|
After putting this together and thinking about it more I tend to agree with @ravage84 that this isn't relevant to the cookbook. Perhaps the entire "generating coverage" section should be done away with as if they use phpunit, they know they can generate coverage. (Perhaps this was leftover from the simpletest days where you went through a cake shell to do everything?) |
|
Merging as having simple tasks like generating coverage in our docs makes our user's lives easier as they don't have to hunt through phpunit's docs too. |
Is this too opinionated? I mean, it is faster, but perhaps not in all cases.
Here's my app's performance, for example (had to reinstall xdebug, forgot how fast
phpdbgactually was 😄 ):