Document fluent route changes. #5019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the old behavior in comments.
ravage84
requested changes
Jun 9, 2017
Member
ravage84
left a comment
ravage84
left a comment
There was a problem hiding this comment.
Good job! Just minor stuff as far as I skimmed through.
en/development/routing.rst
Outdated
|
|
||
| // Set the matching patterns for route elements | ||
| ->setPatterns([ | ||
| 'slug' => '[a-z0-9-_]+' |
en/development/routing.rst
Outdated
| // Set the matching patterns for route elements | ||
| ->setPatterns([ | ||
| 'slug' => '[a-z0-9-_]+' | ||
| 'lang' => 'en|fr|es' |
en/development/routing.rst
Outdated
| // will simply map ":id" to $articleId in your action | ||
| 'pass' => ['id', 'slug'], | ||
| // Define a pattern that `id` must match. | ||
| 'id' => '[0-9]+' |
en/development/routing.rst
Outdated
| ); | ||
|
|
||
| // Match multiple verbs | ||
| // Prior to 3.5 use $options[_method] to set method |
Member
Author
|
Thanks @ravage84 |
ravage84
approved these changes
Jun 10, 2017
Member
|
Thanks! |
HavokInspiration
added a commit
that referenced
this pull request
Jul 7, 2017
6 tasks
ryoichi-u
added a commit
to ryoichi-u/docs
that referenced
this pull request
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation for the new fluent methods on Route. I've also broken the new features section up by package as it was becoming a wall of un-scanable text.
I've tried to follow the latest decisions on documenting the most recent version, and including previous version compatibility in follow up examples or in comments.