Documenting cache fallback #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jun 22, 2017
| configuration would fall back to writing to the ``default`` cache configuration. | ||
| If writing to the ``default`` cache configuration *also* failed in this scenario, the | ||
| engine would fall back once again to the ``NullEngine`` and prevent the application | ||
| from throwing an uncaught exception. |
Member
There was a problem hiding this comment.
Could you include a .. versionadded:: 3.5.0 admonition here for folks using older versions.
ravage84
reviewed
Jun 22, 2017
| 'prefix' => 'cake_redis_', | ||
| 'host' => '127.0.0.1', | ||
| 'port' => 6379, | ||
| 'fallback' => 'default', |
Member
There was a problem hiding this comment.
Just curious. What happens if one configures the same engine as fallback (e.g. by accident)? Do we have a clear exception for that? Something like "You are trying to configure the engine itself as its fallback"...
This would be a hard misconfiguration, something that SHOULD throw an exception, IMHO.
Member
Author
There was a problem hiding this comment.
That's pretty much exactly the exception it throws 😄 I did that exact thing while writing this haha
ravage84
approved these changes
Jun 22, 2017
HavokInspiration
added a commit
that referenced
this pull request
Jul 10, 2017
6 tasks
ryoichi-u
added a commit
to ryoichi-u/docs
that referenced
this pull request
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since engines now default to falling back to the
NullEngine, I felt it important to document in the Behavior Changes section of the migration docs.