Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Sep 30, 2023

No description provided.

@ADmad ADmad added this to the 5.x milestone Sep 30, 2023
Comment on lines +54 to +55
If you create a plugin manually under the ``plugins`` folder then will need to
tell ``composer`` to refresh its autoloading cache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you create a plugin manually under the ``plugins`` folder then will need to
tell ``composer`` to refresh its autoloading cache:
If you create a plugin under the ``plugins`` directory of your application then will need to
tell ``composer`` to refresh its autoloading cache:

Copy link
Member Author

@ADmad ADmad Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the word "manually" to indicate as opposed to baking, since baking a plugin already runs composer dumpautoload now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a word missing after "then"

@markstory markstory merged commit bc8b87c into 5.x Oct 2, 2023
@markstory markstory deleted the plugin-loading branch October 2, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants