Conversation
Added track_total_hits in count function
|
Unit tests are failing because of required stability of dependencies. Should we relax that requirement or wait a stable release from Have someway to support both ES versions (6.x and 7.x)? |
| $connection = $this->_repository->getConnection(); | ||
| $index = $this->_repository->getName(); | ||
| $type = $connection->getIndex($index)->getType($this->_repository->getType()); | ||
| $searchObject = $connection->getIndex($index)->createSearch($this->_repository->getType()); |
There was a problem hiding this comment.
The current syntax of createSearch() expect a string|array|\Elastica\Query as first parameter.
Maybe we can replace the instantiation of $searchObject with directly use Index::search, just like:
return $connection->getIndex($index)->search($query, $this->_searchOptions);There was a problem hiding this comment.
Hi, good point. I've changed it now. Hope it works
|
This pull request is stale because it has been open 30 days with no activity. Remove the |
|
@markstory should this be closed with your new changes? |
|
Perhaps. These changes would enable the 3.x compatible version of the plugin to work with elasticsearch 7. The changes I've made are for the 4.x compatible version. |
5 participants
Use the latest ruflin/elastica (master)
Fixes total hits 10k limit
I haven't tested it with a Elastic Search 6.x server but I assume it may cause some issues due to using elastica branch 7.x