Merged
Conversation
markstory
reviewed
May 20, 2020
| * @param string $name The name of the class to use | ||
| * @return $this | ||
| */ | ||
| public function setEntityClass($name) |
Member
There was a problem hiding this comment.
There is one minor change left on your other pull request. After that I can get it merged. Once it is merged, could these changes be rebased as there are a lot of overlapping changes right now.
Contributor
Author
There was a problem hiding this comment.
I tried review boths PR and don't find anything left - just some docs. Can you point to me?
Updated with docs and a fix for Index looking for documents on entity namespace. Included some tests.
Update tests Correct namespace of app test, so App can find internal classes Fix tests expecting a generic Document when exists a proper document for it Fix Index using Model/Entity as type to load Document Include same tests and fix other metions to table/rows
Contributor
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes as I did on 2.x branch.