fix: Error Messages Not Displayed for Nested Array Fields in Form Inputs#324
Merged
Merged
Conversation
markstory
reviewed
Dec 3, 2024
| } | ||
|
|
||
| if (!$errors && $entityErrors && !is_array($entity)) { | ||
| if (!$errors && $entityErrors) { |
Member
There was a problem hiding this comment.
Looking good, we'll need to get some tests added before we can merge this though. This class has some existing tests https://github.com/cakephp/elastic-search/blob/4.x/tests/TestCase/View/Form/DocumentContextTest.php
I'm happy to help if you need a hand.
Contributor
Author
There was a problem hiding this comment.
I am unable to set up the test environment, so adding test code is difficult. Could you please assist me with this?
I believe the issue can be reproduced by specifying the following data in new Article and triggering the corresponding error:
{
"name": {
"ja": [
{
"family_name": "XX",
"given_name": "XX"
}
],
"en": [
{
"family_name": "XX",
"given_name": "XXX"
}
]
}
}
Member
|
Thank you 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#323