Skip to content

Update broken book links#1087

Merged
dereuromark merged 1 commit into
cakephp:5.xfrom
PioterLearns:fix-broen-book-links
May 21, 2026
Merged

Update broken book links#1087
dereuromark merged 1 commit into
cakephp:5.xfrom
PioterLearns:fix-broen-book-links

Conversation

@PioterLearns
Copy link
Copy Markdown
Contributor

Fixed a bunch of 404 Book links.

Most of them in annotations of tests - let me know if they're too much of a hassle to look through, and I should have let them be. I might do fixes for other repos.

Admittedly I didn't bother to run any tests, as I didn't touch any logic, so everything should work as it did before.

Side note: Your CONTRIBUTING.md says to use master branch by default, which doesn't exist;)

column metadata of your tables. Otherwise, you might end up with errors about
columns not existing when performing operations on those new columns. The
CakePHP core includes a [Schema Cache Shell](https://book.cakephp.org/5/en/console-and-shells/schema-cache.html) that you can use:
CakePHP core includes a [Schema Cache Shell](https://book.cakephp.org/5/console-commands/schema-cache.html) that you can use:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt it https://book.cakephp.org/5.x/console-commands/schema-cache.html etc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other links were in that format, so I left it as is since it redirects to 5.x I can change it to explicitly do 5.x if you prefer

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know what @LordSimal or @josbeir would recommend here, lets wait for them.
Great initiative!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both /5/ and /5.x/ are valid and work.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.x is the "correct" version here as we have a redirect for 5 => 5.x or basically any version as you can see here

@dereuromark dereuromark requested review from LordSimal and josbeir May 21, 2026 13:58
@dereuromark dereuromark merged commit 78a1e6b into cakephp:5.x May 21, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants