Fixups from Migrator pull request, and CI to GitHub Actions#494
Merged
dereuromark merged 12 commits into3.nextfrom Jun 14, 2021
Merged
Fixups from Migrator pull request, and CI to GitHub Actions#494dereuromark merged 12 commits into3.nextfrom
dereuromark merged 12 commits into3.nextfrom
Conversation
Member
markstory
commented
Jun 14, 2021
markstory
commented
- Do a few fixups for Issue #487 Create the test schema with migrations (Draft) #488
- Port CI configuration to GitHub Actions as travis is on the way out.
Codecov Report
@@ Coverage Diff @@
## 3.next #494 +/- ##
=========================================
Coverage ? 89.56%
Complexity ? 662
=========================================
Files ? 34
Lines ? 2069
Branches ? 0
=========================================
Hits ? 1853
Misses ? 216
Partials ? 0
Continue to review full report at Codecov.
|
This will help github CI work better.
dereuromark
reviewed
Jun 14, 2021
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php-version: ['7.2', '7.4'] |
Member
There was a problem hiding this comment.
Suggested change
| php-version: ['7.2', '7.4'] | |
| php-version: ['7.2', '8 0'] |
Member
Author
There was a problem hiding this comment.
I don't know if we've done the work to get migrations working on 8.0. I can add that to the matrix once tests are passing again.
dereuromark
reviewed
Jun 14, 2021
Member
|
I will get this merged, as we can do the PHPStan as follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.