Skip to content

Conversation

@Iandenh
Copy link
Contributor

@Iandenh Iandenh commented Oct 13, 2017

No description provided.

@dereuromark
Copy link
Member

You could include a sniffer here for the PHP7+ travis run - refs https://github.com/spryker/code-sniffer/blob/master/Spryker/ruleset.xml#L23-L24

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #1204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1204   +/-   ##
======================================
  Coverage      72%     72%           
======================================
  Files          35      35           
  Lines        5598    5598           
======================================
  Hits         4031    4031           
  Misses       1567    1567
Impacted Files Coverage Δ
src/Phinx/Db/Adapter/SQLiteAdapter.php 86.65% <ø> (ø) ⬆️
src/Phinx/Console/Command/AbstractCommand.php 52.38% <ø> (ø) ⬆️
src/Phinx/Db/Adapter/AdapterWrapper.php 66.23% <ø> (ø) ⬆️
src/Phinx/Db/Adapter/TablePrefixAdapter.php 79.61% <ø> (ø) ⬆️
src/Phinx/Migration/AbstractMigration.php 100% <ø> (ø) ⬆️
src/Phinx/Db/Adapter/MysqlAdapter.php 97.84% <ø> (ø) ⬆️
src/Phinx/Console/PhinxApplication.php 100% <ø> (ø) ⬆️
src/Phinx/Db/Table.php 96.24% <ø> (ø) ⬆️
src/Phinx/Db/Adapter/SqlServerAdapter.php 0% <ø> (ø) ⬆️
src/Phinx/Migration/Manager.php 89.88% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3b427...40e5be6. Read the comment docs.

@ADmad
Copy link
Member

ADmad commented Oct 13, 2017

@dereuromark CakePHP's coding standard already has sniff for alphabetical ordering.

@ADmad ADmad merged commit 14882c3 into cakephp:master Oct 13, 2017
@dereuromark
Copy link
Member

Ah, riight :)

@Iandenh Iandenh deleted the patch-1 branch October 13, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants