cs fixes: spacing and whitespaces #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 16, 2017
| $this->assertRegExp('/\s*up 20120103083300 2012-01-11 23:53:36 2012-01-11 23:53:37 *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*up 20120815145812 2012-01-16 18:35:40 2012-01-16 18:35:41 Example *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*down 20120111235330 TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20120103083300 2012-01-11 23:53:36 2012-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
stickler-ci
reviewed
Oct 16, 2017
| $this->assertRegExp('/\s*up 20160103083300 2016-01-11 23:53:36 2016-01-11 23:53:37 *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*up 20160815145812 2016-01-16 18:35:40 2016-01-16 18:35:41 Example *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*down 20160111235330 Foo\\\\Bar\\\\TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20160103083300 2016-01-11 23:53:36 2016-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
stickler-ci
reviewed
Oct 16, 2017
| '\s*down 20150111235330 Baz\\\\TestMigration'.PHP_EOL. | ||
| '\s*down 20150116183504 Baz\\\\TestMigration2'.PHP_EOL. | ||
| '\s*down 20160111235330 Foo\\\\Bar\\\\TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20160103083300 2016-01-11 23:53:36 2016-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
stickler-ci
reviewed
Oct 16, 2017
| // note that the order is important: missing migrations should appear before down migrations | ||
| $this->assertRegExp('/\s*up 20120111235330 2012-01-16 18:35:40 2012-01-16 18:35:41 TestMigration'.PHP_EOL. | ||
| '\s*up 20120116183504 2012-01-16 18:35:40 2012-01-16 18:35:41 TestMigration2'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20120111235330 2012-01-16 18:35:40 2012-01-16 18:35:41 TestMigration' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 121 characters
stickler-ci
reviewed
Oct 16, 2017
| // note that the order is important: missing migrations should appear before down migrations | ||
| $this->assertRegExp('/\s*up 20160111235330 2016-01-16 18:35:40 2016-01-16 18:35:41 Foo\\\\Bar\\\\TestMigration'.PHP_EOL. | ||
| '\s*up 20160116183504 2016-01-16 18:35:40 2016-01-16 18:35:41 Foo\\\\Bar\\\\TestMigration2'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20160111235330 2016-01-16 18:35:40 2016-01-16 18:35:41 Foo\\\\Bar\\\\TestMigration' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 135 characters
stickler-ci
reviewed
Oct 16, 2017
| // place with regard to other up non-missing migrations) | ||
| $this->assertRegExp('/\s*up 20120103083300 2012-01-11 23:53:36 2012-01-11 23:53:37 *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*up 20120111235330 2012-01-16 18:35:40 2012-01-16 18:35:41 TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20120103083300 2012-01-11 23:53:36 2012-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
stickler-ci
reviewed
Oct 16, 2017
| // place with regard to other up non-missing migrations) | ||
| $this->assertRegExp('/\s*up 20160103083300 2016-01-11 23:53:36 2016-01-11 23:53:37 *\*\* MISSING \*\*'.PHP_EOL. | ||
| '\s*up 20160111235330 2016-01-16 18:35:40 2016-01-16 18:35:41 Foo\\\\Bar\\\\TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20160103083300 2016-01-11 23:53:36 2016-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
stickler-ci
reviewed
Oct 16, 2017
| '\s*up 20150111235330 2015-01-16 18:35:40 2015-01-16 18:35:41 Baz\\\\TestMigration'.PHP_EOL. | ||
| '\s*down 20150116183504 Baz\\\\TestMigration2'.PHP_EOL. | ||
| '\s*down 20160111235330 Foo\\\\Bar\\\\TestMigration'.PHP_EOL. | ||
| $this->assertRegExp('/\s*up 20120103083300 2012-01-11 23:53:36 2012-01-11 23:53:37 *\*\* MISSING \*\*' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Line exceeds 120 characters; contains 126 characters
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
=======================================
Coverage 72.18% 72.18%
=======================================
Files 35 35
Lines 5584 5584
=======================================
Hits 4031 4031
Misses 1553 1553
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.