Add php 8.2 to github actions and update versions#2096
Conversation
| - '1.x' | ||
| pull_request: | ||
| branches: | ||
| - '*' |
There was a problem hiding this comment.
It should be noted that using * will not work if the branch name includes a /. If you're looking to match any branch name, you'd want to use **. Alternatively, remove the entire clause and just do:
pull_request:and I think that'll work the same way as doing:
pull_request:
branches:
- '**'There was a problem hiding this comment.
Hmm, that was just copied from our cakephp repo. I'll check it out.
There was a problem hiding this comment.
Relevant GH action docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
*: Matches zero or more characters, but does not match the/character. For example,Octo*matchesOctocat.
**: Matches zero or more of any character.
There was a problem hiding this comment.
I'm willing to bet that the original workflow for cake was copied from somewhere. I wish they'd document the defaults better. All I see is a comment explaining the default activity types that triggers, although it's logical that no branch filter means all branches.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
Looks like we need to clean this up for all repos.
There was a problem hiding this comment.
yeah, remove it alltogether, just keep the pull_request: part.
There was a problem hiding this comment.
Yeah, when GH actions was original released, I remember a lot of the original examples and early repos would do *, as I remember hitting this issue in some of my early usages of GH actions. It's definitely not the most intuitive thing, especially as I think the vast majority of repos probably don't use / in branch names and so would never hit this case.
No description provided.