Skip to content

Add php 8.2 to github actions and update versions#2096

Merged
othercorey merged 1 commit into0.xfrom
php-82
Jul 4, 2022
Merged

Add php 8.2 to github actions and update versions#2096
othercorey merged 1 commit into0.xfrom
php-82

Conversation

@othercorey
Copy link
Copy Markdown
Contributor

No description provided.

@othercorey othercorey merged commit 8ceeeaf into 0.x Jul 4, 2022
@othercorey othercorey deleted the php-82 branch July 4, 2022 05:00
Comment thread .github/workflows/ci.yml
- '1.x'
pull_request:
branches:
- '*'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that using * will not work if the branch name includes a /. If you're looking to match any branch name, you'd want to use **. Alternatively, remove the entire clause and just do:

  pull_request:

and I think that'll work the same way as doing:

  pull_request:
    branches:
      - '**'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that was just copied from our cakephp repo. I'll check it out.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant GH action docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

*: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.
**: Matches zero or more of any character.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to bet that the original workflow for cake was copied from somewhere. I wish they'd document the defaults better. All I see is a comment explaining the default activity types that triggers, although it's logical that no branch filter means all branches.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

Looks like we need to clean this up for all repos.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, remove it alltogether, just keep the pull_request: part.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when GH actions was original released, I remember a lot of the original examples and early repos would do *, as I remember hitting this issue in some of my early usages of GH actions. It's definitely not the most intuitive thing, especially as I think the vast majority of repos probably don't use / in branch names and so would never hit this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants