Skip to content

Test enhancement about class loading and assertion#46

Merged
markstory merged 1 commit intocakephp:masterfrom
open-source-contributions:test_enhancement
Aug 18, 2020
Merged

Test enhancement about class loading and assertion#46
markstory merged 1 commit intocakephp:masterfrom
open-source-contributions:test_enhancement

Conversation

@peter279k
Copy link
Copy Markdown
Contributor

Changed log

  • The PluginInstallerTest class namespace should change into Cake\Test\Composer\TestCase\Installer so that it can let composer load testing classes automatically. And the tests/bootstrap.php file can be removed.
  • Using the assertSame assertion to make assertion equals checking strict.
  • According to the PHPUnit fixtures, it should be the protected function setUp() and protected function tearDown() methods.

@markstory markstory merged commit 9014a73 into cakephp:master Aug 18, 2020
@markstory
Copy link
Copy Markdown
Member

Thank you 👍

@peter279k peter279k deleted the test_enhancement branch August 19, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants