Skip to content

Add more tests.#22

Merged
markstory merged 2 commits intomasterfrom
more-tests
Jan 28, 2020
Merged

Add more tests.#22
markstory merged 2 commits intomasterfrom
more-tests

Conversation

@markstory
Copy link
Copy Markdown
Member

I'm not sure how to proceed on QueueManager::push() as I've not figured out where in Enqueue to attach a listener/extension/callback/logger. @josegonzalez do you know how that could be done?

I'm not sure how to proceed on QueueManager::push() as I've not figured
out where in Enqueue to attach a listener/extension/callback/logger.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2020

Codecov Report

Merging #22 into master will increase coverage by 6.94%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     39.17%   46.11%   +6.94%     
- Complexity       74       75       +1     
============================================
  Files             9        9              
  Lines           217      219       +2     
============================================
+ Hits             85      101      +16     
+ Misses          132      118      -14
Impacted Files Coverage Δ Complexity Δ
src/QueueManager.php 59.52% <100%> (+37.02%) 15 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1bc8b...58883b2. Read the comment docs.

@josegonzalez
Copy link
Copy Markdown
Member

@markstory what exactly are you trying to do with attaching an extension? You can only attach one extension at a time, so maybe a super-class of the one we already attach, and make the attached extension editable?

@markstory
Copy link
Copy Markdown
Member Author

The scenario I want to write a test for is that QueueManager::push() actually pushes an event to the queue. If mocks are awkward it might be better to do an integration test of push + consuming from a file based queue.

@josegonzalez
Copy link
Copy Markdown
Member

Yeah that might make more sense to me.

@markstory markstory merged commit 7240c2d into master Jan 28, 2020
@markstory markstory deleted the more-tests branch January 28, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants