Skip to content

Conversation

@Saheb
Copy link
Collaborator

@Saheb Saheb commented Oct 20, 2017

No description provided.

@simonsouter
Copy link
Contributor

simonsouter commented Oct 20, 2017

Also Fixes (#125)

@simonsouter simonsouter changed the title POC for adding callbacks in AutoParititon Mode Add optional callbacks in AutoParititon Mode Oct 27, 2017
@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #124 into master will decrease coverage by 0.1%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   64.07%   63.96%   -0.11%     
==========================================
  Files          16       16              
  Lines         515      519       +4     
  Branches       30       31       +1     
==========================================
+ Hits          330      332       +2     
- Misses        185      187       +2
Impacted Files Coverage Δ
...cala/cakesolutions.kafka/testkit/KafkaServer.scala 89.23% <100%> (ø) ⬆️
.../cakesolutions/kafka/akka/KafkaConsumerActor.scala 56.8% <100%> (-0.47%) ⬇️
...ala/cakesolutions/kafka/akka/TrackPartitions.scala 75.47% <75%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f5df9...940a40d. Read the comment docs.

@simonsouter simonsouter merged commit 452ee69 into master Nov 3, 2017
@simonsouter simonsouter deleted the callbacksInAutoPartition branch November 3, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants