feat: Add full names in the description of dynamic events.

[jyellapu]

What does this PR do?

Updates description of only dynamic events with full names of the attendees.

Sample screenshots:

• Dynamic events:
  With two users:
  

With more than two users:

*Normal event:

Fixes # (issue)
Fixes #10194
/claim #10194

Requirement/Documentation

• If there is a requirement document, please, share it here.
• If there is ab UI/UX design document, please, share it here.

Type of change

• New feature (non-breaking change which adds functionality)

How should this be tested?

Create dynamic events with 2 or more attendees, the description on booker should have full names of the attendees, if number of attendees is more than 2 then it should show first two attendees full names with more at the end.

• Are there environment variables that should be set?
• What are the minimal test data to have?
• What is expected (happy path) to have (input and output)?
• Any other important info that could help to test that PR

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• I haven't read the contributing guide
• My code doesn't follow the style guidelines of this project
• I haven't commented my code, particularly in hard-to-understand areas
• I haven't checked if my PR needs changes to the documentation
• I haven't checked if my changes generate no new warnings
• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 27, 2023 8:46am

[vercel]

@jyellapu is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for following the naming conventions! 🙏

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[PeerRich]

would this also reflect in the calendar and emails correctly?

[PeerRich]

can you make a test booking and show the email template and calendar entry?

[alishaz-polymath]

Thank you for raising this PR 🙏

There are still places which contain the old description. The changes look to be only counting towards the booking availability page.

For instance, even the dynamic event list, and the success page have the old description. Potentially, even emails and events created in connected calendars would have the old description.

[jyellapu]

Sure, I'm running mailhog locally but getting 'SEND_BROKEN_INTEGRATION_ERROR Error: Missing credentials for "PLAIN"'
error, debugging the setup.

Bookings page:

[alishaz-polymath]

We have a guide for Setting up Mailtrap for local email debugging. You can use that if that helps. Ideally, we want the connected calendars & emails to show event name as the new description. That's where it matters the most.

[jyellapu]

@alishaz-polymath In the screenshots you shared above, it is event title which we are displaying.

[jyellapu]

@alishaz-polymath I'm going through the code, the issue seems to be since dynamic events doesn't have eventId but they just have slug, thus whenever eventId is missing in the code it is getting default event with that event's slug, as default events are predefined in the code, thus the title we see above is coming from predefined default event.
Ref: https://github.com/calcom/cal.com/blob/main/packages/features/bookings/lib/handleNewBooking.ts#L692

Could you confirm once again, what is expected in the email templates and in the calendar events?

[PeerRich]

@alishaz-polymath i have another idea, what if we make a mandatory input called "title of this call" that has a max. char limit and we use that input as the title for the meeting?

IMO we can even have this empty here:

and only focus on title in calendar and confirmation email (based on the user input)

[alishaz-polymath]

@alishaz-polymath i have another idea, what if we make a mandatory input called "title of this call" that has a max. char limit and we use that input as the title for the meeting?

IMO we can even have this empty here:

and only focus on title in calendar and confirmation email (based on the user input)

I agree. That looks a lot better. ♥️♥️

[jyellapu]

@alishaz-polymath i have another idea, what if we make a mandatory input called "title of this call" that has a max. char limit and we use that input as the title for the meeting?

IMO we can even have this empty here:

and only focus on title in calendar and confirmation email (based on the user input)

Yes it was good one, that way user was given flexibility to describe the booking.

[alishaz-polymath]

Minor changes requested. 🙏
Also, please ensure the Type Checks don't fail.

[alishaz-polymath]

@PeerRich Are we happy with no description? The PR essentially allows booker to create a title for the event being booked, but the description is empty.

[PeerRich]

@PeerRich Are we happy with no description? The PR essentially allows booker to create a title for the event being booked, but the description is empty.

yes i think no description is fine for the booking page as long as we have a required title and the title of the calendar entry looks good

[alishaz-polymath]

Hey @jyellapu just FYI, I'll review this today 🙏

[emrysal]

@alishaz-polymath I merged #9931 which also removes the description; it condenses all dynamic events into one with multiple durations.

[alishaz-polymath]

@alishaz-polymath I merged #9931 which also removes the description; it condenses all dynamic events into one with multiple durations.

I see. Let me test after update locally to see how it changes things for this PR (if it does). Thanks for the update @emrysal 🙏

[alishaz-polymath]

Looks good to me, works well 🚀
Thank you for the PR @jyellapu 🙏

[PeerRich]

misclicked. merging!