Skip to content

chore: Remove env file cache#10297

Merged
zomars merged 16 commits into
mainfrom
chore/remove-env-file
Jul 28, 2023
Merged

chore: Remove env file cache#10297
zomars merged 16 commits into
mainfrom
chore/remove-env-file

Conversation

@keithwillcode

@keithwillcode keithwillcode commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the cache layer for GitHub env

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Verify all GitHub workflows pass

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

@keithwillcode keithwillcode self-assigned this Jul 21, 2023
@vercel

vercel Bot commented Jul 21, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:37pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:37pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:37pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:37pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 21, 2023 4:37pm
qa ⬜️ Ignored (Inspect) Jul 21, 2023 4:37pm

@github-actions

github-actions Bot commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@alwaysmeticulous

alwaysmeticulous Bot commented Jul 21, 2023

Copy link
Copy Markdown

🤖 Meticulous spotted visual differences in 27 of 213 screens tested: view and approve differences detected.

Last updated for commit 1dbe5d1. This comment will update as new commits are pushed.

@deploysentinel

Copy link
Copy Markdown

Current Playwright Test Results Summary

✅ 73 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/21/2023 02:35:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8b5521c

Started: 07/21/2023 02:34:02pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
16.84% (50) 50 / 297 runs
failed over last 7 days
36.03% (107) 107 / 297 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode

Copy link
Copy Markdown
Contributor Author

@zomars @emrysal These checks are failing since the file that "main" workflows are looking for is now gone.

@keithwillcode

Copy link
Copy Markdown
Contributor Author

Can see here that the workflow was successful. https://github.com/calcom/cal.com/actions/runs/5623428205

@hariombalhara

Copy link
Copy Markdown
Member

What's the reasoning behind removing it ? I see one immediate disadvantage that all env variables are duplicated at many places now.

@zomars

zomars commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

What's the reasoning behind removing it ? I see one immediate disadvantage that all env variables are duplicated at many places now.

Dealing with stale cache, new variables not being picked up, less steps overall. I think is a nice tradeoff for some code repetition.

@zomars zomars left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@zomars zomars merged commit e6ae69a into main Jul 28, 2023
@zomars zomars deleted the chore/remove-env-file branch July 28, 2023 15:24
sean-brydon pushed a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only High priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants