fix: ratelimit - updates#10347
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
| common: new Ratelimit({ | ||
| redis, | ||
| analytics: true, | ||
| prefix: "ratelimit", | ||
| limiter: Ratelimit.fixedWindow(200, "60s"), | ||
| }), |
There was a problem hiding this comment.
New limiting type that will be used across higher called apis
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 74 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/24/2023 09:49:04pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 96fe263 Started: 07/24/2023 09:47:19pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
9.90% (31)31 / 313 runsfailed over last 7 days |
36.42% (114)114 / 313 runsflaked over last 7 days |
|
🤖 Meticulous spotted visual differences in 37 of 228 screens tested: view and approve differences detected. Last updated for commit 96fe263. This comment will update as new commits are pushed. |
| prefix: "ratelimit", | ||
| limiter: Ratelimit.fixedWindow(10, "60s"), | ||
| }), | ||
| common: new Ratelimit({ |
There was a problem hiding this comment.
| common: new Ratelimit({ | |
| common: () => new Ratelimit({ |
We should invoque the limiters otherwise we're loading all of them instead of only the ones needed. Not a big deal since there's only 3 but a good practice for scaling
There was a problem hiding this comment.
Getting some errors doing this - will create issue n follow up!
4 participants
Adds a few changes for rate limiting