perf: reduce number of api calls in event types#10381
Merged
Merged
Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 49 of 213 screens tested: view and approve differences detected. Last updated for commit b809c14. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 106 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/28/2023 02:38:43pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b809c14 Started: 07/28/2023 02:36:39pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
3.90% (9)9 / 231 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0.34% (1)1 / 290 runfailed over last 7 days |
2.07% (6)6 / 290 runsflaked over last 7 days |
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
0.70% (2)2 / 286 runsfailed over last 7 days |
14.34% (41)41 / 286 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
3.51% (10)10 / 285 runsfailed over last 7 days |
3.86% (11)11 / 285 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.30% (3)3 / 231 runsfailed over last 7 days |
95.24% (220)220 / 231 runsflaked over last 7 days |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
keithwillcode
added
High priority
Udit-takkar
commented
Jul 27, 2023
| const CTA = ({ data }: { data: GetByViewerResponse }) => { | ||
| const { t } = useLocale(); | ||
|
|
||
| const query = trpc.viewer.eventTypes.getByViewer.useQuery(); |
Contributor
Author
There was a problem hiding this comment.
we were using this twice with different inputs
trpc.viewer.eventTypes.getByViewer.useQuery();
trpc.viewer.eventTypes.getByViewer.useQuery(filters && { filters });
PeerRich
previously approved these changes
Jul 28, 2023
PeerRich
left a comment
PeerRich
left a comment
Member
There was a problem hiding this comment.
tested, feels faster already!
emrysal
approved these changes
Jul 28, 2023
sean-brydon
pushed a commit
that referenced
this pull request
Jul 31, 2023
* perf: reduce number of api calls in event types Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * chore Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * perf: use staleTime and cacheTime Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Peer Richelsen <peeroke@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Type of change