Skip to content

perf: Remove IP ban and tweak matcher accordingly#10418

Merged
emrysal merged 1 commit into
mainfrom
perf/remove-ip-ban-from-middleware
Jul 27, 2023
Merged

perf: Remove IP ban and tweak matcher accordingly#10418
emrysal merged 1 commit into
mainfrom
perf/remove-ip-ban-from-middleware

Conversation

@emrysal

@emrysal emrysal commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

  • The IP ban feature in CloudFlare (for cal.com) actually works, we can use that instead of middleware and reduce our middleware executions.
  • Also tweaks the matchers

@vercel

vercel Bot commented Jul 27, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:49pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:49pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:49pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:49pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 27, 2023 1:49pm

@emrysal emrysal changed the title Remove IP ban and tweak matcher accordingly perf: Remove IP ban and tweak matcher accordingly Jul 27, 2023
@github-actions

github-actions Bot commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@alwaysmeticulous

alwaysmeticulous Bot commented Jul 27, 2023

Copy link
Copy Markdown

🤖 Meticulous spotted visual differences in 28 of 174 screens tested: view and approve differences detected.

Last updated for commit 1f14d5d. This comment will update as new commits are pushed.

@hariombalhara hariombalhara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !!

@emrysal emrysal enabled auto-merge (squash) July 27, 2023 13:49
@emrysal emrysal marked this pull request as draft July 27, 2023 13:52
auto-merge was automatically disabled July 27, 2023 13:52

Pull request was converted to draft

@emrysal emrysal marked this pull request as ready for review July 27, 2023 13:54
@deploysentinel

deploysentinel Bot commented Jul 27, 2023

Copy link
Copy Markdown

Current Playwright Test Results Summary

✅ 106 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/27/2023 01:56:23pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1f14d5d

Started: 07/27/2023 01:54:41pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
1.38% (4) 4 / 290 runs
failed over last 7 days
6.55% (19) 19 / 290 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.82% (4) 4 / 220 runs
failed over last 7 days
94.55% (208) 208 / 220 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
1.37% (4) 4 / 292 runs
failed over last 7 days
8.56% (25) 25 / 292 runs
flaked over last 7 days

View Detailed Build Results


@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emrysal emrysal merged commit 32068a6 into main Jul 27, 2023
@emrysal emrysal deleted the perf/remove-ip-ban-from-middleware branch July 27, 2023 14:02
@keithwillcode keithwillcode added High priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive labels Jul 27, 2023
@keithwillcode keithwillcode added this to the v3.2 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only High priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants