Skip to content

fix: do not delete last schedule#10444

Merged
emrysal merged 1 commit into
calcom:mainfrom
rkreddy99:rkreddy99/cal-2215
Jul 31, 2023
Merged

fix: do not delete last schedule#10444
emrysal merged 1 commit into
calcom:mainfrom
rkreddy99:rkreddy99/cal-2215

Conversation

@rkreddy99

Copy link
Copy Markdown
Contributor

What does this PR do?

Make sure that's the user does not delete their last schedule.

Fixes #10302

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Try to delete last remaining schedule by modifying request, should get an error

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel

vercel Bot commented Jul 28, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 1:21pm

@vercel

vercel Bot commented Jul 28, 2023

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions github-actions Bot added bookings area: bookings, availability, timezones, double booking Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jul 28, 2023
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emrysal emrysal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, nice!

@emrysal emrysal merged commit d21135e into calcom:main Jul 31, 2023
sean-brydon pushed a commit that referenced this pull request Aug 1, 2023
Co-authored-by: rkreddy99 <rreddy@e2clouds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2215] By modifying the request for delete on schedules I am able to delete my last schedule

2 participants