fix: use cloudflare real IP#10449
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
sean-brydon
commented
Jul 28, 2023
Comment on lines
+13
to
+16
| let xff = | ||
| request instanceof Request | ||
| ? request.headers.get("cf-connecting-ip") | ||
| : request.headers["cf-connecting-ip"]; |
Member
Author
There was a problem hiding this comment.
emrysal
approved these changes
Jul 28, 2023
emrysal
left a comment
emrysal
left a comment
Contributor
There was a problem hiding this comment.
lgtm (let's see if it works)
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 106 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/28/2023 03:10:58pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f2fb1c8 Started: 07/28/2023 03:08:42pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.45% (4)4 / 275 runsfailed over last 7 days |
36.73% (101)101 / 275 runsflaked over last 7 days |
📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0% (0)0 / 150 runsfailed over last 7 days |
6% (9)9 / 150 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 149 runsfailed over last 7 days |
14.77% (22)22 / 149 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
0.70% (2)2 / 287 runsfailed over last 7 days |
14.63% (42)42 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1 • Initial Attempt |
0.35% (1)1 / 288 runfailed over last 7 days |
5.90% (17)17 / 288 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.29% (3)3 / 232 runsfailed over last 7 days |
95.26% (221)221 / 232 runsflaked over last 7 days |
emrysal
pushed a commit
that referenced
this pull request
Jul 28, 2023
sean-brydon
added a commit
that referenced
this pull request
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use cloudflare real ip instead of forwarded for if exists