fix: Fixed 10080 settings sidebar scrolling issue#10471
Merged
Conversation
|
@bhargavtenali is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
Medium priority
Contributor
|
Thank you for following the naming conventions! 🙏 |
github-actions
Bot
added
⚡ Quick Wins
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
bhargavtenali
changed the title
Udit-takkar
reviewed
Jul 31, 2023
Udit-takkar
reviewed
Jul 31, 2023
bhargavtenali
force-pushed
the
fix/top-banner-z-index
branch
from
7ec3823 to
d82b2d3
Compare
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Udit-takkar
previously approved these changes
Jul 31, 2023
Udit-takkar
left a comment
Udit-takkar
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I fixed the type error
emrysal
reviewed
Jul 31, 2023
emrysal
approved these changes
Jul 31, 2023
emrysal
left a comment
emrysal
left a comment
Contributor
There was a problem hiding this comment.
Re-approving @Udit-takkar after fixing failing type error.
sean-brydon
pushed a commit
that referenced
this pull request
Aug 1, 2023
* fix: #10080 settings sidebar scrolling issue * fix: type error Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * Fixed type error --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Alex van Andel <me@alexvanandel.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #10080
Video Link : https://drive.google.com/file/d/1gMdWe0NhVEB6i2pXIzfTpelFNvQKGL5E/view?usp=sharing
Hi @Jaibles @PeerRich @Udit-takkar
Hope you are doing well.
After hours of debugging to find the exact root cause. This is what I found:
Issue and Fix Summary:
Type of change
How should this be tested?
When Any topBar is present (eg: Organisation Upgrade Banner) -> Go Settings Page -> scroll through the sidebar present in Settings Page
Video Link : https://drive.google.com/file/d/1gMdWe0NhVEB6i2pXIzfTpelFNvQKGL5E/view?usp=sharing
Mandatory Tasks