Skip to content

refactor: Fixed workflowReminder test + refactored reminderSchedule#10487

Merged
emrysal merged 1 commit into
mainfrom
refactor/make-reminderScheduler-bit-more-readable
Jul 31, 2023
Merged

refactor: Fixed workflowReminder test + refactored reminderSchedule#10487
emrysal merged 1 commit into
mainfrom
refactor/make-reminderScheduler-bit-more-readable

Conversation

@emrysal

@emrysal emrysal commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

  • workflowReminder refactor to improve readability
  • Fix failing workflowReminder test

@emrysal emrysal requested a review from CarinaWolli July 31, 2023 17:13
@vercel

vercel Bot commented Jul 31, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 5:20pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 5:20pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 5:20pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 5:20pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 31, 2023 5:20pm

@github-actions

github-actions Bot commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Jul 31, 2023
@emrysal emrysal changed the title Fixed workflowReminder test + refactored reminderSchedule refactor: Fixed workflowReminder test + refactored reminderSchedule Jul 31, 2023
@alwaysmeticulous

alwaysmeticulous Bot commented Jul 31, 2023

Copy link
Copy Markdown

🤖 Meticulous spotted visual differences in 35 of 159 screens tested: view and approve differences detected.

Last updated for commit 78dac78. This comment will update as new commits are pushed.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel

deploysentinel Bot commented Jul 31, 2023

Copy link
Copy Markdown

Current Playwright Test Results Summary

✅ 10 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/31/2023 05:32:16pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 78dac78

Started: 07/31/2023 05:30:53pm UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0.35% (1) 1 / 286 run
failed over last 7 days
4.90% (14) 14 / 286 runs
flaked over last 7 days
FORM_SUBMITTED can submit a form and get a submission event
Retry 1Initial Attempt
1.76% (5) 5 / 284 runs
failed over last 7 days
20.07% (57) 57 / 284 runs
flaked over last 7 days

View Detailed Build Results


@CarinaWolli CarinaWolli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @emrysal 🙏

@emrysal emrysal merged commit 9498ad4 into main Jul 31, 2023
@emrysal emrysal deleted the refactor/make-reminderScheduler-bit-more-readable branch July 31, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants