fix: eslint crashing#10491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@O4epegb is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 |
| import type { RouterOutputs } from "@calcom/trpc/react"; | ||
| import { trpc } from "@calcom/trpc/react"; | ||
| import type { App as AppType } from "@calcom/types/App"; | ||
| import type { App as AppType, AppFrontendPayload } from "@calcom/types/App"; |
There was a problem hiding this comment.
This is the only change basically, everything else is autoformat etc
O4epegb
changed the title
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
And now after the fix there are 55 eslint-prettier errors, should I fix them here too? Or make them warnings? |
|
Can't help here but came to say well done! Saw that error before myself but never got the full call stack, so decided to ignore it in the end. Others have had the problem too, see #10292. |
3 participants
What does this PR do?
yarn lintcrashes for me locally (and on CI too apparently, e.g. other random PR https://github.com/calcom/cal.com/actions/runs/5718689486/job/15495018755?pr=10488#step:5:18) because in App.tsx one of the type has the same name as App component, bothApp, basically shadowingIt's actually valid TS code, but it seems it requires some package updates to parse without errors, and since right now it's hard to update package versions and yarn.lock correctly, I decided to just fix this one line.
Type of change
How should this be tested?
Run
yarn lint, it should not crashMandatory Tasks