fix: inconsistent timezones in e2e tests#11841
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
zomars
added
🐛 bug
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/16/2023 11:33:33pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 349d8c0 Started: 10/16/2023 11:30:58pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
7.85% (26)26 / 331 runsfailed over last 7 days |
90.94% (301)301 / 331 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.31% (11)11 / 332 runsfailed over last 7 days |
37.35% (124)124 / 332 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Profile page is loaded for users in Organization
Retry 1 • Initial Attempt |
1.62% (5)5 / 309 runsfailed over last 7 days |
28.80% (89)89 / 309 runsflaked over last 7 days |
PeerRich
previously approved these changes
Oct 11, 2023
zomars
force-pushed
the
10-11-fix_inconsistent_timezones_in_e2e_tests
branch
from
63f514c to
f0ae8bd
Compare
zomars
force-pushed
the
10-11-fix_inconsistent_timezones_in_e2e_tests
branch
from
18f1fb8 to
349d8c0
Compare
|
|
||
| import { selectFirstAvailableTimeSlotNextMonth, teamEventSlug, teamEventTitle } from "../lib/testUtils"; | ||
| import type { TimeZoneEnum } from "./types"; | ||
| import { TimeZoneEnum } from "./types"; |
Member
There was a problem hiding this comment.
nit: I think we should move TimeZoneEnum from types to somewhere else as it's not just a type, a value also.
| type BookingFixture = ReturnType<typeof createBookingFixture>; | ||
|
|
||
| // We default all dayjs calls to use Europe/London timezone | ||
| const dayjs = (...args: Parameters<typeof _dayjs>) => _dayjs(...args).tz("Europe/London"); |
Member
There was a problem hiding this comment.
nit: We could use Timezone.UK here also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refs #2337
Up until recently, running e2e tests locally didn't take into account local timezones. Now it seems like it is and is triggering the update timezone popup, getting tests to timeout.
Type of change
How should this be tested?
On a browser with a different timezone (like America/Mazatlan), run e2e tests. The popup should not appear.
Mandatory Tasks