Skip to content

perf: yarn patch dayjs#13542

Merged
keithwillcode merged 8 commits intomainfrom
perf/yarn-patch-dayjs
Feb 5, 2024
Merged

perf: yarn patch dayjs#13542
keithwillcode merged 8 commits intomainfrom
perf/yarn-patch-dayjs

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode commented Feb 5, 2024

What does this PR do?

Fixes #13358

Extension of #13512 but used yarn patch to put the changes directly into the dayjs package

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Ensure test suite is passing and date functionality across the system is stable

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 7:35pm
api ❌ Failed (Inspect) Feb 5, 2024 7:35pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 7:35pm
cal-demo ⬜️ Ignored (Inspect) Feb 5, 2024 7:35pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 7:35pm
qa ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 7:35pm
ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 7:35pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only foundation labels Feb 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Feb 5, 2024

Current Playwright Test Results Summary

✅ 440 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/05/2024 07:51:16pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5267ded

Started: 02/05/2024 07:40:31pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and select Question Multiple Email required and select required
Retry 1Initial Attempt
0.36% (1) 1 / 276 run
failed over last 7 days
4.35% (12) 12 / 276 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text required and checkbox not required
Retry 1Initial Attempt
0% (0) 0 / 266 runs
failed over last 7 days
1.50% (4) 4 / 266 runs
flaked over last 7 days

📄   apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With All Questions Selecting and filling all questions as optional
Retry 1Initial Attempt
0.36% (1) 1 / 278 run
failed over last 7 days
5.04% (14) 14 / 278 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Multi email Question Radio required and Multi email required
Retry 1Initial Attempt
0.38% (1) 1 / 263 run
failed over last 7 days
4.18% (11) 11 / 263 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
2.20% (6) 6 / 273 runs
failed over last 7 days
19.05% (52) 52 / 273 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 1Initial Attempt
15% (42) 42 / 280 runs
failed over last 7 days
15.71% (44) 44 / 280 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone required and Long text not required
Retry 2Retry 1Initial Attempt
0.37% (1) 1 / 273 run
failed over last 7 days
5.49% (15) 15 / 273 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Group Question Address and checkbox group not required
Retry 1Initial Attempt
3.69% (11) 11 / 298 runs
failed over last 7 days
6.04% (18) 18 / 298 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
0% (0) 0 / 283 runs
failed over last 7 days
1.41% (4) 4 / 283 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 295 runs
failed over last 7 days
12.20% (36) 36 / 295 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode marked this pull request as ready for review February 5, 2024 17:23
@keithwillcode keithwillcode requested a review from a team February 5, 2024 17:24
Comment thread package.json
@keithwillcode keithwillcode added performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive Urgent Created by Linear-GitHub Sync and removed core area: core, team members only labels Feb 5, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Feb 5, 2024
@keithwillcode keithwillcode marked this pull request as draft February 5, 2024 17:55
@keithwillcode keithwillcode marked this pull request as ready for review February 5, 2024 17:58
@github-actions github-actions Bot added the bookings area: bookings, availability, timezones, double booking label Feb 5, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Feb 5, 2024
Comment thread package.json Outdated
zomars
zomars previously approved these changes Feb 5, 2024
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@keithwillcode keithwillcode marked this pull request as ready for review February 5, 2024 19:30
@keithwillcode keithwillcode enabled auto-merge (squash) February 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive Urgent Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2994] Fix round robin perf issues

2 participants