perf: add luxon to date ranges by keithwillcode · Pull Request #13505 · calcom/cal.diy

keithwillcode · 2024-02-02T11:07:45Z

What does this PR do?

Fixes #13358.

Speeds up date range calculations by a factor of 5x, on average.

Type of change

Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Ensure all test suites are passing and slots functionality is not affected

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2024-02-02T11:07:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 2, 2024 11:14am
api	❌ Failed (Inspect)			Feb 2, 2024 11:14am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Feb 2, 2024 11:14am
cal-demo	⬜️ Ignored (Inspect)		Feb 2, 2024 11:14am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Feb 2, 2024 11:14am
ui	⬜️ Ignored (Inspect)	Visit Preview	Feb 2, 2024 11:14am

github-actions · 2024-02-02T11:07:56Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

socket-security · 2024-02-02T11:09:28Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/luxon@3.4.4	None	`0`	4.33 MB	icambron

View full report↗︎

github-actions · 2024-02-02T11:19:50Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-02-02T11:21:43Z

Current Playwright Test Results Summary

✅ 441 Passing - ❌ 3 Failing - ⚠️ 17 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/02/2024 11:29:15am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0d868c3

Started: 02/02/2024 11:19:56am UTC

❌ Failures

📄 apps/web/playwright/booking-limits.e2e.ts • 2 Failures

Top 1 Common Error Messages

`expect(received).toBe(expected) // Object.is equality`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking limits year Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: true Received: false`	20.41% (40) 40 / 196 runs failed over last 7 days	0% (0) 0 / 196 runs flaked over last 7 days
Booking limits multiple Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: 0 Received: -1`	21.03% (41) 41 / 195 runs failed over last 7 days	0% (0) 0 / 195 runs flaked over last 7 days

📄 apps/web/playwright/booking/availability.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Check availability tab in a event-type Check availability in event type Retry 2 • Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded. `Test timeout of 60000ms exceeded.`	14.09% (31) 31 / 220 runs failed over last 7 days	43.18% (95) 95 / 220 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group required and Phone required Retry 1 • Initial Attempt	0% (0) 0 / 218 runs failed over last 7 days	4.13% (9) 9 / 218 runs flaked over last 7 days

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	1.48% (3) 3 / 203 runs failed over last 7 days	33.99% (69) 69 / 203 runs flaked over last 7 days

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Login and logout tests -- legacy Login flow validations -- legacy Should warn when user does not exist Retry 1 • Initial Attempt	0.50% (1) 1 / 202 run failed over last 7 days	5.45% (11) 11 / 202 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled Retry 1 • Initial Attempt	0.49% (1) 1 / 204 run failed over last 7 days	7.35% (15) 15 / 204 runs flaked over last 7 days

📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Checkbox Group Question Address and checkbox group not required Retry 1 • Initial Attempt	5.08% (12) 12 / 236 runs failed over last 7 days	6.78% (16) 16 / 236 runs flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and select Question Address required and select required Retry 2 • Retry 1 • Initial Attempt	0.45% (1) 1 / 220 run failed over last 7 days	2.27% (5) 5 / 220 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation Retry 1 • Initial Attempt	1.87% (4) 4 / 214 runs failed over last 7 days	12.62% (27) 27 / 214 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook Retry 2 • Retry 1 • Initial Attempt	3.23% (7) 7 / 217 runs failed over last 7 days	13.82% (30) 30 / 217 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user enabling recurring event comes with default options Retry 1 • Initial Attempt	0% (0) 0 / 225 runs failed over last 7 days	13.78% (31) 31 / 225 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

`null`	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	-3.11% (-7) -7 / 225 runs failed over last 7 days	44.89% (101) 101 / 225 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-77.10% (-101) -101 / 131 runs failed over last 7 days	77.10% (101) 101 / 131 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-66.41% (-87) -87 / 131 runs failed over last 7 days	69.47% (91) 91 / 131 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-71.65% (-91) -91 / 127 runs failed over last 7 days	71.65% (91) 91 / 127 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-71.65% (-91) -91 / 127 runs failed over last 7 days	71.65% (91) 91 / 127 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-71.65% (-91) -91 / 127 runs failed over last 7 days	71.65% (91) 91 / 127 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-71.65% (-91) -91 / 127 runs failed over last 7 days	71.65% (91) 91 / 127 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-71.65% (-91) -91 / 127 runs failed over last 7 days	71.65% (91) 91 / 127 runs flaked over last 7 days

View Detailed Build Results

keithwillcode · 2024-02-05T17:44:33Z

Closing since #13542 is handling our perf issues. Will reopen this later if we decide to go forward with luxon.

keithwillcode added 4 commits February 1, 2024 15:05

perf: Replace dayjs with luxon for date range calculations

c01ee15

Converting processWorkingHours to use luxon

09798c1

Fixed bug with weekday

37a4c39

Fixed the unit tests

0d868c3

keithwillcode added the Urgent Created by Linear-GitHub Sync label Feb 2, 2024

keithwillcode requested a review from a team February 2, 2024 11:07

keithwillcode added performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive foundation labels Feb 2, 2024

github-actions Bot added the bookings area: bookings, availability, timezones, double booking label Feb 2, 2024

keithwillcode added the core area: core, team members only label Feb 2, 2024

keithwillcode changed the title ~~Perf/add luxon to date ranges~~ perf: add luxon to date ranges Feb 2, 2024

vercel Bot deployed to Preview – ai February 2, 2024 11:11 View deployment

PeerRich modified the milestones: v3.9, v3.8 Feb 5, 2024

keithwillcode closed this Feb 5, 2024

keithwillcode deleted the perf/add-luxon-to-date-ranges branch September 17, 2025 11:50

Conversation

keithwillcode commented Feb 2, 2024

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Uh oh!

vercel Bot commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Feb 2, 2024

Uh oh!

github-actions Bot commented Feb 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

❌ Failures

Top 1 Common Error Messages

Test Case Results

Test Case Results

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Uh oh!

keithwillcode commented Feb 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Feb 2, 2024 •

edited

Loading

github-actions Bot commented Feb 2, 2024 •

edited

Loading

deploysentinel Bot commented Feb 2, 2024 •

edited

Loading