Skip to content

fix: atoms docs #17556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ryukemeister merged 6 commits into from
Nov 9, 2024
Merged

fix: atoms docs #17556

Ryukemeister merged 6 commits into from
Nov 9, 2024

Conversation

@Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Nov 8, 2024 •
edited
Loading

What does this PR do?

  • Testing out some fixes

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Nov 8, 2024
@vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:21am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:21am

@Ryukemeister Ryukemeister marked this pull request as ready for review November 8, 2024 14:14
@graphite-app graphite-app bot requested a review from a team November 8, 2024 14:14
@dosubot dosubot bot added the docs area: docs, documentation, cal.com/docs label Nov 8, 2024
@graphite-app
Copy link

graphite-app bot commented Nov 8, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (11/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Ryukemeister Ryukemeister enabled auto-merge (squash) November 8, 2024 14:15
@Ryukemeister Ryukemeister disabled auto-merge November 8, 2024 14:16
@Ryukemeister Ryukemeister marked this pull request as draft November 8, 2024 14:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

E2E results are ready!

@Ryukemeister Ryukemeister marked this pull request as ready for review November 9, 2024 07:21
@Ryukemeister Ryukemeister enabled auto-merge (squash) November 9, 2024 07:25
@Ryukemeister Ryukemeister merged commit fc35f9d into main Nov 9, 2024
@Ryukemeister Ryukemeister deleted the atoms-loom-fix branch November 9, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Praashh Praashh Praashh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core area: core, team members only docs area: docs, documentation, cal.com/docs platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ryukemeister @Praashh @keithwillcode