Skip to content

perf: Ignore node_modules in Tailwind preset#20058

Merged
keithwillcode merged 3 commits intomainfrom
perf/ignore-node-modules-tailwind-preset
Mar 13, 2025
Merged

perf: Ignore node_modules in Tailwind preset#20058
keithwillcode merged 3 commits intomainfrom
perf/ignore-node-modules-tailwind-preset

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

What does this PR do?

Thanks to @timneutkens for #20041. Since mentioned that this isn't specific to Next 15, pulling in now to get benefits.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure Tailwind styles are not affected in the app

@graphite-app graphite-app bot requested a review from a team March 13, 2025 15:41
@keithwillcode keithwillcode added core area: core, team members only foundation labels Mar 13, 2025
@keithwillcode keithwillcode self-assigned this Mar 13, 2025
@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Mar 13, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 13, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/13/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/13/25)

1 label was added to this PR based on Keith Williams's automation.

emrysal
emrysal previously approved these changes Mar 13, 2025
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithwillcode keithwillcode enabled auto-merge (squash) March 13, 2025 15:55
eunjae-lee
eunjae-lee previously approved these changes Mar 13, 2025
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow didn't even think about this case. awesome change.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 5:40pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 5:40pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2025

E2E results are ready!

zomars
zomars previously approved these changes Mar 13, 2025
Comment thread packages/config/tailwind-preset.js Outdated
@hbjORbj hbjORbj dismissed stale reviews from zomars, eunjae-lee, and emrysal via ade5a09 March 13, 2025 17:39
Comment thread packages/config/tailwind-preset.js
@hbjORbj
Copy link
Copy Markdown
Contributor

hbjORbj commented Mar 13, 2025

@keithwillcode
follow-up PR here: #20067

@keithwillcode keithwillcode merged commit 034dfc8 into main Mar 13, 2025
47 of 48 checks passed
@keithwillcode keithwillcode deleted the perf/ignore-node-modules-tailwind-preset branch March 13, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants