feat: implement booking page error boundary#20492
Merged
Conversation
dosubot
bot
added
booking-page
hbjORbj
commented
Apr 1, 2025
|
|
||
| import { type PageProps } from "@lib/d/[link]/[slug]/getServerSideProps"; | ||
|
|
||
| import BookingPageErrorBoundary from "@components/error/BookingPageErrorBoundary"; |
Contributor
Author
There was a problem hiding this comment.
Client-side errors thrown in Booker will now get caught in BookingPageErrorBoundary
Contributor
Author
There was a problem hiding this comment.
Errors thrown in RSCs will render:
While client-side errors caught in BookingPageErrorBoundary will render:
Contributor
There was a problem hiding this comment.
@hbjORbj How does it look in a production build?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/01/25)1 reviewer was added to this PR based on Keith Williams's automation. |
emrysal
approved these changes
Apr 1, 2025
Contributor
E2E results are ready! |
emrysal
pushed a commit
that referenced
this pull request
Apr 1, 2025
* implement booking page error boundary * use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?