fix: switch saveMode for SaveFilterSegmentButton#20502
Merged
CarinaWolli merged 2 commits intomainfrom Apr 2, 2025
Merged
Conversation
eunjae-lee
commented
Apr 2, 2025
| const setPageSizeAndGoToFirstPage = useCallback( | ||
| (newPageSize: number | null) => { | ||
| setPageSize(newPageSize === DEFAULT_PAGE_SIZE ? null : newPageSize); | ||
| setPageSize(newPageSize === defaultPageSize ? null : newPageSize); |
Contributor
Author
There was a problem hiding this comment.
We should use the actual defaultPageSize given from the caller.
| columnVisibility, | ||
| columnSizing, | ||
| perPage: 10, | ||
| perPage: pageSize, |
Contributor
Author
There was a problem hiding this comment.
We didn't use the actual value here
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/02/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (04/02/25)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
CarinaWolli
approved these changes
Apr 2, 2025
Contributor
E2E results are ready! |
alishaz-polymath
pushed a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
SaveFilterSegmentButton.The
saveModeshould change based on whether a filter segment is currently selected. This PR updates thesaveModevalue accordingly.Visual Demo (For contributors especially)
Because of this bug, we had this issue:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
<input>won't show up (it used to show up occasionally)