Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/AvfzU8zMZxKLAHJdXCPPABsDXTE7 [Deployment for 2b99f4e canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/2oHR2K56JjkAPagtXCZBceGKBLhL [Deployment in progress for 2b99f4e] |
8d7f847 to
f78cfa3
Compare
|
@zomars I've added e2e test for |
zomars
left a comment
There was a problem hiding this comment.
Fixed E2E tests, tested and can confirm that is working flawlessly.
alannnc
left a comment
There was a problem hiding this comment.
Minor code improvements suggested
What does this PR do?
+between their usernames.loom video
Fixes #1661
What needs to be done:
/[user1]+[user2]+[user3]15min,30min,60min/[user1]+[user2]+[user3]/15min/[user1]+[user2]+[user3]/15minQuirks & Follow up
Even if thedisableGuestistruefor the dynamic group events in case of rescheduling the booked event, it becomes wonky and adds all but one of the 'group' being booked as guests which might mean that they receive the emails twice as they might be added as attendee more than once, and this might keep growing with each reschedule of the same event. Exploring this currently.Edge case: Even if one of the users in the group has disabled their dynamic booking bookability, the booking page would throw an error.updated to handle it better [ref:
]
Currently disabling guest for this booking type because of the way guests are identified for rescheduling. It would require a rework of the reschedule page specifically how the guests are pulled in, so we can do that in a follow up PR
Exception handling when one of the two
usernames/slugsdon't exist, the page says the user has not set up any events (hinting at the existing user) however, it should ideally state that one of the username slugs are incorrect. Can be improved in a follow up PRWe can improve the design of these errors once (cc: @Jaibles) designs are ready
Type of change
How should this be tested?
/settings/profileThen proceed with the following tests:
<slug1+slug2+slug3>etc.In localhost, it would be
http://localhost:3000/slug1+slug2+slug3. Proceed with the booking and complete it.