Skip to content

Show eventDescription on email#2371

Merged
zomars merged 22 commits intomainfrom
feat/event-description
Apr 7, 2022
Merged

Show eventDescription on email#2371
zomars merged 22 commits intomainfrom
feat/event-description

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

What does this PR do?

If there is a description present - it is now displayed in invite emails and also calendar. This description comes from the set description by the user.

The old 'Description' field has been renamed to 'Additional Notes' to reflect what it actually is.

Fixes #1459

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Add a description to an event
  • Book an event.
  • Check emails - description will now appear
  • Check calendar - description will be present

Checklist

  • I haven't read the contributing guide

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/H9xf6jwwtLboJzXtrVobxSYsGfsD
✅ Preview: Canceled

[Deployment for fcbc94b canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/4xT3VR6obYS4piGTtiCjeKvym8x3
✅ Preview: https://calendso-git-feat-event-description-cal.vercel.app

Comment thread apps/web/lib/emails/templates/attendee-scheduled-email.ts
Comment thread apps/web/lib/emails/templates/organizer-cancelled-email.ts Outdated
@vercel vercel Bot temporarily deployed to Preview – docs April 4, 2022 17:45 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 4, 2022 17:45 Inactive
Comment thread apps/web/lib/emails/templates/attendee-declined-email.ts Outdated
Comment thread apps/web/lib/emails/templates/attendee-request-email.ts Outdated
Comment thread apps/web/pages/api/book/event.ts
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@vercel vercel Bot temporarily deployed to Preview – calendso April 4, 2022 17:55 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 4, 2022 17:55 Inactive
@sean-brydon sean-brydon requested a review from zomars April 4, 2022 19:42
@zomars
Copy link
Copy Markdown
Contributor

zomars commented Apr 4, 2022

@sean-brydon we've got some type errors:
image

Copy link
Copy Markdown
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on 2 emails templates

@vercel vercel Bot temporarily deployed to Preview – calendso April 5, 2022 19:52 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 5, 2022 19:56 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 5, 2022 19:56 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 6, 2022 16:34 Inactive
@zomars zomars enabled auto-merge (squash) April 6, 2022 16:34
@vercel vercel Bot temporarily deployed to Preview – calendso April 6, 2022 16:34 Inactive
@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Apr 6, 2022
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 12:52 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 12:52 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 13:43 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 13:43 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 14:36 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 14:36 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 15:36 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 15:36 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 16:28 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 16:28 Inactive
@zomars
Copy link
Copy Markdown
Contributor

zomars commented Apr 7, 2022

The Webhooks payload changed so the snapshot no longer matches and the tests fail. Will update the snapshot.

@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 17:41 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 17:41 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 18:05 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 18:05 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 18:07 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 7, 2022 18:11 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 7, 2022 18:14 Inactive
@zomars zomars merged commit 96f6294 into main Apr 7, 2022
@zomars zomars deleted the feat/event-description branch April 7, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Description to Calendar Body

4 participants