Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/GqAjVeV23XNvfymnJMdenvgjZt8S [Deployment for b7c18a1 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/DaArsG6zKrqhFUrmpAa1nFGCCRRJ |
| const { data: session, status } = useSession(); | ||
| const loading = status === "loading"; | ||
| const router = useRouter(); | ||
| const shouldDisplayUnauthed = router.pathname.startsWith("/apps"); |
There was a problem hiding this comment.
shouldDisplayUnauthorised or shouldDisplayUnauthorized
| const { data: session, status } = useSession(); | ||
| const loading = status === "loading"; | ||
| const router = useRouter(); | ||
| const shouldDisplayUnauthed = router.pathname.startsWith("/apps"); |
There was a problem hiding this comment.
instead of hard-coding/apps we can introduce a prop on Shell to determine whether it should render when unauth or not
There was a problem hiding this comment.
As for now we don't plan to add any more public routes. We can do that when that changes.
5 participants
What does this PR do?
Fixes #2420
Type of change
How should this be tested?