Skip to content

Fix: Cancelled Slot not available for booking#2479

Merged
zomars merged 2 commits intomainfrom
fix/booking-cancellation-slot-not-available
Apr 13, 2022
Merged

Fix: Cancelled Slot not available for booking#2479
zomars merged 2 commits intomainfrom
fix/booking-cancellation-slot-not-available

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Apr 13, 2022

What does this PR do?

Fixes # (issue)
Fixes the issue where the cancelled Slot was not available for booking. This is as reported over twist and I am able to replicate it.

Will be updating the cancellation test to do a booking again because that is what's the definition of cancellation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/3VfHY5c9dYvRKRZZNGQdxLnyewFh
✅ Preview: Ignored

[Deployment for 5746b2c canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/EmvKyA74kiHEf63Fm77rqi9s9Kx4
✅ Preview: https://calendso-git-fix-booking-cancellation-slot-not-available-cal.vercel.app

@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 12:59 Inactive
Copy link
Copy Markdown
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. Good thinking!

@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 17:00 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 17:00 Inactive
Copy link
Copy Markdown
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, big miss from us. Thanks @hariombalhara

@zomars zomars merged commit ce476bf into main Apr 13, 2022
@zomars zomars deleted the fix/booking-cancellation-slot-not-available branch April 13, 2022 17:22
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants