Fix: Cancelled Slot not available for booking#2479
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/3VfHY5c9dYvRKRZZNGQdxLnyewFh [Deployment for 5746b2c canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/EmvKyA74kiHEf63Fm77rqi9s9Kx4 |
joeauyeung
approved these changes
Apr 13, 2022
Contributor
joeauyeung
left a comment
There was a problem hiding this comment.
The changes make sense to me. Good thinking!
zomars
approved these changes
Apr 13, 2022
Contributor
zomars
left a comment
There was a problem hiding this comment.
Wow, big miss from us. Thanks @hariombalhara
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Fixes the issue where the cancelled Slot was not available for booking. This is as reported over twist and I am able to replicate it.
Will be updating the cancellation test to do a booking again because that is what's the definition of cancellation.
Type of change
How should this be tested?
Checklist