-
Notifications
You must be signed in to change notification settings - Fork 11.5k
refactor: use structured logger in video adapters #26285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove debug console.log/console.error statements - Add logger.debug for observability (meeting lifecycle events) - Add logger.error with safe error pattern (message + name only) - Fix error messages to avoid exposing response details
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
volnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
- Use named import for prisma (default export deprecated) - Remove error details from logs to avoid exposing secrets - Remove redundant try/catch blocks (errors propagate naturally)
|
Thanks for the review @volnei ! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/app-store/webex/lib/VideoApiAdapter.ts">
<violation number="1" location="packages/app-store/webex/lib/VideoApiAdapter.ts:175">
P2: Error details are lost in this catch block. The error object is not captured, making debugging significantly harder. For structured logging, capture the error and include it:
```typescript
} catch (err) {
logger.error("Error fetching Webex availability", { error: err });
return [];
}
```</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
volnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🚀
What does this PR do?
Replaces console statements with structured logger in Office365 (Teams) and Webex video adapters. This improves observability and aligns with the logging patterns used across the codebase.
Changes
console.log/console.errorwithlogger.debug/logger.errorHow to test
Creating Teams/Webex meetingTeams/Webex meeting created { meetingId: ... }Mandatory Tasks