Skip to content

Conversation

@pedroccastro
Copy link
Contributor

What does this PR do?

Replaces console statements with structured logger in Office365 (Teams) and Webex video adapters. This improves observability and aligns with the logging patterns used across the codebase.

Changes

  • Replaced console.log/console.error with logger.debug/logger.error
  • Added debug logs for meeting lifecycle events (create, delete)
  • Standardized error logging with structured format (message + name)
  • Fixed error messages to use null-safe access and clearer descriptions

How to test

  1. Connect Office365 (Teams) or Webex integration
  2. Create a booking with video conferencing
  3. Check server logs for structured debug output:
    • Creating Teams/Webex meeting
    • Teams/Webex meeting created { meetingId: ... }
  4. Verify no raw console output in production logs

Mandatory Tasks

  • I have self-reviewed the code
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

- Remove debug console.log/console.error statements
- Add logger.debug for observability (meeting lifecycle events)
- Add logger.error with safe error pattern (message + name only)
- Fix error messages to avoid exposing response details
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 6, 2026
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 6, 2026
@pedroccastro pedroccastro marked this pull request as ready for review January 6, 2026 12:11
@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
cal Ignored Ignored Jan 7, 2026 0:21am
cal-companion Ignored Ignored Preview Jan 7, 2026 0:21am
cal-eu Ignored Ignored Jan 7, 2026 0:21am

@graphite-app graphite-app bot requested a review from a team January 6, 2026 12:11
@graphite-app graphite-app bot added the core area: core, team members only label Jan 6, 2026
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comments

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

- Use named import for prisma (default export deprecated)
- Remove error details from logs to avoid exposing secrets
- Remove redundant try/catch blocks (errors propagate naturally)
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 7, 2026
@pedroccastro
Copy link
Contributor Author

Thanks for the review @volnei ! 🙌
Agreed with all points and addressed them in the last commit: fixed the Prisma import (named export), removed error details from logs to avoid exposing secrets, and removed redundant try/catch blocks so errors propagate naturally

@pedroccastro pedroccastro marked this pull request as ready for review January 7, 2026 00:21
@github-actions github-actions bot removed the Stale label Jan 7, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/app-store/webex/lib/VideoApiAdapter.ts">

<violation number="1" location="packages/app-store/webex/lib/VideoApiAdapter.ts:175">
P2: Error details are lost in this catch block. The error object is not captured, making debugging significantly harder. For structured logging, capture the error and include it:

```typescript
} catch (err) {
  logger.error("Error fetching Webex availability", { error: err });
  return [];
}
```</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀

@pedroccastro pedroccastro merged commit 30ef388 into main Jan 7, 2026
72 of 73 checks passed
@pedroccastro pedroccastro deleted the refactor/video-adapters-cleanup branch January 7, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants