Skip to content

refactor: Extract schedule determination to seperate fn #26600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emrysal merged 3 commits into from
Jan 11, 2026
Merged

refactor: Extract schedule determination to seperate fn #26600

emrysal merged 3 commits into from
Jan 11, 2026

Conversation

@emrysal
Copy link
Contributor

@emrysal emrysal commented Jan 9, 2026 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Extracted schedule selection into a dedicated function to simplify getUserAvailability and make timezone fallback logic clearer. No functional changes expected.

  • Refactors
    • Added detectEventTypeScheduleForUser to choose schedule and report isDefaultSchedule/isTimezoneSet.
    • Introduced ScheduleWithoutTimeZone and DEFAULT_SCHEDULE_DATA.
    • Simplified timezone resolution, using delegated calendar TZ only when needed.
    • Made GetUserAvailabilityResult explicit and typed _getUserAvailability accordingly.
    • Imported WorkingHoursWithUserId and removed inline schedule logic and redundant debug logging.

Written for commit 6bf6b44. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
api-v2 Ignored Ignored Preview Jan 10, 2026 4:51pm
cal Ignored Ignored Jan 10, 2026 4:51pm
cal-companion Ignored Ignored Preview Jan 10, 2026 4:51pm
cal-eu Ignored Ignored Jan 10, 2026 4:51pm

@emrysal emrysal marked this pull request as ready for review January 9, 2026 02:42
@emrysal emrysal requested a review from a team as a code owner January 9, 2026 02:42
@emrysal emrysal enabled auto-merge (squash) January 9, 2026 02:42
@graphite-app graphite-app bot added core area: core, team members only foundation labels Jan 9, 2026
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

volnei
volnei approved these changes Jan 11, 2026
View reviewed changes
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emrysal emrysal merged commit 312733c into main Jan 11, 2026
72 of 74 checks passed
@emrysal emrysal deleted the refactor/extract-schedule-logic-to-fn branch January 11, 2026 22:44
Anshumancanrock pushed a commit to Anshumancanrock/cal.com that referenced this pull request Jan 12, 2026
@emrysal @Anshumancanrock
refactor: Extract schedule determination to seperate fn (calcom#26600)
4450fc3 
* refactor: Extract schedule determination to seperate fn

* refactor: Extract schedule detection to seperate file and add tests

* RouterOutputs should be used in hooks, not direct type imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@volnei volnei volnei approved these changes

Assignees

No one assigned

Labels

core area: core, team members only foundation ready-for-e2e size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emrysal @volnei